Hi Julian,

According to your recommendation, I've created a Jira issue for that and
submitted a pull request. Could you please review the pull request?

Jira: https://issues.apache.org/jira/browse/SLING-12848
Pull request:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/15

On 2025/06/30 05:49:00 Jörg Hoh wrote:
> Hi Herman,
>
> can you outline what problem you are trying to solve?
>
> Isn't the SlingRepository service (
>
https://sling.apache.org/apidocs/sling13/org/apache/sling/jcr/api/SlingRepository.html
)
> providing exactly the same functionality as the Oak ContentRepository ((
>
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-api/src/main/java/org/apache/jackrabbit/oak/api/ContentRepository.java
> )?
>
> Jörg
>
>
>
>
> Am Fr., 27. Juni 2025 um 17:42 Uhr schrieb Herman Ciechanowiec <
> her...@ciechanowiec.eu>:
>
> > Dear Apache Sling Team,
> >
> > Jackrabbit Oak has internal dependencies on the
> > org.apache.jackrabbit.oak.api.ContentRepository service. For instance,
the
> > registration of
> >
> >
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.jmx.SynchronizationMBean
> > will not occur if a ContentRepository service is unavailable (see link
> > <
> >
https://github.com/apache/jackrabbit-oak/blob/b5c317af752b3c421c9d341a7cfca407dff29af5/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModuleFactory.java#L203-L206
> > >
> > ).
> >
> > However, the sling-org-apache-sling-jcr-oak-server bundle, which is
> > responsible for repository initialization and initializes the
> > ContentRepository object, does not register it as a ContentRepository
> > service type.
> >
> > What are your thoughts on changing this as demonstrated in my proof of
> > concept: link
> > <
> >
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/compare/master...ciechanowiec:sling-org-apache-sling-jcr-oak-server:poc-content-repo-registration
> > >?
> > The change appears to be very simple, and I can submit a pull request
once
> > I receive confirmation that it is worth considering.
> > Kind regards,
> >
> > Herman Ciechanowiec
> > her...@ciechanowiec.eu
> >
>
>
> --
> https://cqdump.joerghoh.de
>

Kind regards,

Herman Ciechanowiec
her...@ciechanowiec.eu

Reply via email to