Robert Munteanu created SLING-12838:
---------------------------------------
Summary: Support for non-OIDC connections broken
Key: SLING-12838
URL: https://issues.apache.org/jira/browse/SLING-12838
Project: Sling
Issue Type: Bug
Components: Authentication
Affects Versions: OAuth Client 0.1.2
Reporter: Robert Munteanu
Fix For: OAuth Client 0.1.4
In
https://github.com/apache/sling-org-apache-sling-auth-oauth-client/commit/3b0ebb96857a13c068c896e1ca9a033aaa9c01f1
the ResolvedOAuthConnection was changed in a way that causes it to fail if an
org.apache.sling.auth.oauth_client.impl.OAuthConnectionImpl instance is passed
to resolve.
The error manifests itself when trying to initiate the OAuth connection
{noformat}
23.06.2025 22:56:51.083 *ERROR* [127.0.0.1 [1750712211081] GET
/system/sling/oauth/entry-point HTTP/1.1] org.apache.sling.engine.impl.SlingR
equestProcessorImpl service: Uncaught Throwable
org.apache.sling.auth.oauth_client.impl.OAuthEntryPointException: Internal error
at
org.apache.sling.auth.oauth_client.impl.OAuthEntryPointServlet.doGet(OAuthEntryPointServlet.java:103)
[org.apache.sling.auth.oaut
h-client:0.1.2]
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
[org.apache.sling.api:2.27.6]
at
org.apache.sling.api.servlets.SlingAllMethodsServlet.mayService(SlingAllMethodsServlet.java:137)
[org.apache.sling.api:2.27.6]
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
[org.apache.sling.api:2.27.6]
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
[org.apache.sling.api:2.27.6]
at
org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:544)
[org.apache.sling.engine:2.16.0]
at
org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
[org.apache.sling.engine:
2.16.0]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:88)
[org.apache.sling.engine:
2.16.0]
at
org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:374)
[org.apache.sling.eng
ine:2.16.0]
at
org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:48)
[org.apache.sling.engine:2.16
.0]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:88)
[org.apache.sling.engine:
2.16.0]
at
org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:113)
[org.apache
.sling.engine:2.16.0]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
[org.apache.sling.engine:
2.16.0]
at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:129)
[org.apache.sling.i18n:2.6.6]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
[org.apache.sling.engine:
2.16.0]
at
com.composum.sling.nodes.mount.remote.RemoteRequestFilter.doFilter(RemoteRequestFilter.java:76)
[com.composum.nodes.console:4.3.4
]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
[org.apache.sling.engine:
2.16.0]
at
org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:249)
[org.apache.sling.eng
ine:2.16.0]
at
org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:129)
[org.apache.sling.engine:2.16.0]
at
org.apache.felix.http.jakartawrappers.ServletWrapper.service(ServletWrapper.java:74)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:128)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
[org.apache.felix.http.jetty:5.1.2
6]
at
org.apache.felix.http.javaxwrappers.FilterChainWrapper.doFilter(FilterChainWrapper.java:45)
[org.apache.felix.http.jetty:5.1.26]
at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:129)
[org.apache.sling.i18n:2.6.6]
at
org.apache.felix.http.jakartawrappers.FilterWrapper.doFilter(FilterWrapper.java:58)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:145)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
[org.apache.felix.http.jetty:5.1.2
6]
at
org.apache.felix.http.javaxwrappers.FilterChainWrapper.doFilter(FilterChainWrapper.java:45)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.sling.engine.impl.log.RequestLoggerFilter.doFilter(RequestLoggerFilter.java:72)
[org.apache.sling.engine:2.16.0]
at
org.apache.felix.http.jakartawrappers.FilterWrapper.doFilter(FilterWrapper.java:58)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:145)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
[org.apache.felix.http.jetty:5.1.2
6]
at
org.apache.felix.http.javaxwrappers.FilterChainWrapper.doFilter(FilterChainWrapper.java:45)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.sling.engine.impl.parameters.RequestParameterSupportConfigurer.doFilter(RequestParameterSupportConfigurer.java:66)
[or
g.apache.sling.engine:2.16.0]
at
org.apache.felix.http.jakartawrappers.FilterWrapper.doFilter(FilterWrapper.java:58)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:145)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
[org.apache.felix.http.jetty:5.1.2
6]
at
org.apache.felix.http.base.internal.dispatch.Dispatcher$1.doFilter(Dispatcher.java:153)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.whiteboard.WhiteboardManager$1.doFilter(WhiteboardManager.java:958)
[org.apache.felix.http.je
tty:5.1.26]
at
org.apache.felix.http.sslfilter.internal.SslFilter.doFilter(SslFilter.java:122)
[org.apache.felix.http.sslfilter:2.0.2]
at
org.apache.felix.http.base.internal.handler.PreprocessorHandler.handle(PreprocessorHandler.java:132)
[org.apache.felix.http.jetty
:5.1.26]
at
org.apache.felix.http.base.internal.whiteboard.WhiteboardManager$1.doFilter(WhiteboardManager.java:964)
[org.apache.felix.http.je
tty:5.1.26]
at
org.apache.felix.http.javaxwrappers.FilterChainWrapper.doFilter(FilterChainWrapper.java:45)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.sling.engine.impl.log.RequestLoggerPreprocessor.doFilter(RequestLoggerPreprocessor.java:47)
[org.apache.sling.engine:2.16.0]
at
org.apache.felix.http.jakartawrappers.FilterWrapper.doFilter(FilterWrapper.java:58)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.handler.PreprocessorHandler.handle(PreprocessorHandler.java:132)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.whiteboard.WhiteboardManager$1.doFilter(WhiteboardManager.java:964)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.whiteboard.WhiteboardManager.invokePreprocessors(WhiteboardManager.java:968)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.dispatch.Dispatcher.dispatch(Dispatcher.java:95)
[org.apache.felix.http.jetty:5.1.26]
at
org.apache.felix.http.base.internal.dispatch.DispatcherServlet.service(DispatcherServlet.java:49)
[org.apache.felix.http.jetty:5.1.26]
at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:614)
[org.apache.felix.http.servlet-api:3.0.0]
at
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:764)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:529)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1580)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1381)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:176)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:484)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1553)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:174)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1303)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:129)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:149)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:122)
[org.apache.felix.http.jetty:5.1.26]
at org.eclipse.jetty.server.Server.handle(Server.java:563)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.HttpChannel$RequestDispatchable.dispatch(HttpChannel.java:1598)
[org.apache.felix.http.jetty:5.1.26]
at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:753)
[org.apache.felix.http.jetty:5.1.26]
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:501)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:287)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:314)
[org.apache.felix.http.jetty:5.1.26]
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:100)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.io.SelectableChannelEndPoint$1.run(SelectableChannelEndPoint.java:53)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.runTask(AdaptiveExecutionStrategy.java:421)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.consumeTask(AdaptiveExecutionStrategy.java:390)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.tryProduce(AdaptiveExecutionStrategy.java:277)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.run(AdaptiveExecutionStrategy.java:199)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:411)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:969)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1194)
[org.apache.felix.http.jetty:5.1.26]
at
org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1149)
[org.apache.felix.http.jetty:5.1.26]
at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.IllegalArgumentException: Unable to resolve
ClientConnection (name=github) of type
org.apache.sling.auth.oauth_client.impl.OAuthConnectionImpl
at
org.apache.sling.auth.oauth_client.impl.ResolvedOAuthConnection.resolve(ResolvedOAuthConnection.java:64)
[org.apache.sling.auth.oauth-client:0.1.2]
at
org.apache.sling.auth.oauth_client.impl.OAuthEntryPointServlet.getAuthenticationRequestUri(OAuthEntryPointServlet.java:109)
[org.apache.sling.auth.oauth-client:0.1.2]
at
org.apache.sling.auth.oauth_client.impl.OAuthEntryPointServlet.doGet(OAuthEntryPointServlet.java:97)
[org.apache.sling.auth.oauth-client:0.1.2]
... 81 common frames omitted
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
