kwin commented on code in PR #61:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/61#discussion_r2159167641
##########
src/main/java/org/apache/sling/api/resource/PersistenceException.java:
##########
@@ -91,4 +95,34 @@ public String getResourcePath() {
public String getPropertyName() {
return this.propertyName;
}
+
+ /**
+ * Returns a message for this exception.
+ * If the cause is not null, it will be appended to the message.
+ * @return The message for this exception
+ */
+ @Override
+ public String getMessage() {
Review Comment:
In general I agree with your point of view, however for PersistenceException
everywhere only a very generic message is used and almost all of them are
triggered by downstream exceptions in the providers. Also we don’t control all
places which evaluate the exception. Do you see any potential downsides of this
except for deviating a bit from Java standard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
