[
https://issues.apache.org/jira/browse/SLING-12742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954562#comment-17954562
]
Robert Munteanu commented on SLING-12742:
-----------------------------------------
[~angela] - yes, I did propose something a long time ago, see
https://cwiki.apache.org/confluence/display/SLING/Enforcing+CI+checks+for+pull+requests
. At this point I think enforcement should come after we have a informal/not
enforced process in place that works.
I fully agree reviews are a net positive, as long as they actually happen.
Keeping in mind that I am probably one of the more unresponsive reviewers in
the Sling project :-) in think we should try to incentivise reviews or keep
reviewers engaged in way or another. Maybe implementing some tooling to send
review reminders? Encouranging people to remove themselves as reviewers if they
don't have the time to review?
> Don't swallow java.io.NotSerializableException in
> JcrPropertyMapCacheEntry.createValue()
> ----------------------------------------------------------------------------------------
>
> Key: SLING-12742
> URL: https://issues.apache.org/jira/browse/SLING-12742
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Affects Versions: JCR Resource 3.3.2
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: JCR Resource 3.3.4
>
>
> Currently a log like this is exposed in case a class cannot be serialized
> (despite having the marker interface Serializable) when an object of that
> type is put into a {{ModifiableValueMap}}:
> {code}
> Caused by: java.lang.IllegalArgumentException: Value can't be stored in the
> repository: <my object>
> at
> org.apache.sling.jcr.resource.internal.helper.JcrPropertyMapCacheEntry.failIfCannotStore(JcrPropertyMapCacheEntry.java:109)
> [org.apache.sling.jcr.resource:3.3.2]
> at
> org.apache.sling.jcr.resource.internal.helper.JcrPropertyMapCacheEntry.<init>(JcrPropertyMapCacheEntry.java:97)
> [org.apache.sling.jcr.resource:3.3.2]
> at
> org.apache.sling.jcr.resource.internal.JcrModifiableValueMap.put(JcrModifiableValueMap.java:63)
> [org.apache.sling.jcr.resource:3.3.2]
> {code}
> The underlying exception was a
> {code}
> java.io.NotSerializableException: java.util.Optional
> {code}
> which was swallowed in
> https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/7d980aa423bf32b639bea5c767d1fe6ec66773b7/src/main/java/org/apache/sling/jcr/resource/internal/helper/JcrPropertyMapCacheEntry.java#L135
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
