raducotescu commented on code in PR #42:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/42#discussion_r2095112502
##########
src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java:
##########
@@ -157,6 +158,13 @@ public class DefaultQueryExecutor implements QueryExecutor
{
" Change ONLY if you know exactly what you are doing."
)
int maxWhitespaceTokens() default 200000;
+
+ @AttributeDefinition(
+ name = "Maximum Field Count",
+ description = "The number of fields queried with an GraphQL
request. This is a safety measure to avoid denial of service attacks." +
+ " Change ONLY if you know exactly what you are doing."
+ )
+ int maxFieldCount() default 200000;
Review Comment:
@schulm, why does Sling need 2x what the library sets by default? Since this
is configurable, I'd like to go with the default. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
