stefan-egli commented on code in PR #43:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/43#discussion_r2086703122
##########
src/main/java/org/apache/sling/event/impl/jobs/queues/QueueManager.java:
##########
@@ -385,8 +385,8 @@ public void remove() {
public void configurationChanged(final boolean active) {
// are we still active?
if ( this.configuration != null ) {
- logger.debug("Topology changed {}", active);
- this.isActive.set(active);
+ logger.debug("Topology changed {}, job processing enabled: {}",
active, configuration.isJobProcessingEnabled());
+ this.isActive.set(active &&
configuration.isJobProcessingEnabled());
clearHaltedTopics("configurationChanged : unhalted topics due to
configuration change");
if ( active ) {
Review Comment:
this should be the new style active - and it is where it becomes a bit
misleading with naming - the `ConfigurationChangeListener` says active is if
`job processing` is active - but the new config param is also called
`jobProcessingEnabled` - which I think is misleading. But in any case, here it
must be the same value as is calculated 2 lines above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
