stefan-egli commented on code in PR #43:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/43#discussion_r2084864940
##########
src/main/java/org/apache/sling/event/impl/jobs/queues/QueueManager.java:
##########
@@ -82,7 +82,7 @@
public class QueueManager
implements Runnable, EventHandler, ConfigurationChangeListener {
- static QueueManager newForTest(EventAdmin eventAdmin, JobConsumerManager
jobConsumerManager,
+ public static QueueManager newForTest(EventAdmin eventAdmin,
JobConsumerManager jobConsumerManager,
Review Comment:
for some reason I'd prefer to keep this package protected - one way to do
this could be to have an explicit eg `QueueManagerAccessor` class in `test`
which would be in the same package (thus this could remain package protected)
and provide it `public` to tests. that way productive could could be more
protected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
