kwin commented on code in PR #56:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#discussion_r2073946949
##########
src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java:
##########
@@ -69,4 +70,19 @@ public Path getPackageRootPath() {
public Collection<PackageInfo> getDependenciesPackageInfo() {
return Collections.emptyList();
}
+
+ @Override
+ public Object setAttribute(String name, Object value) {
Review Comment:
You don't resolve dependencies currently
(https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/40a60fe7e5186a7eb695b1453ab30d6145c04647/src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java#L71)
which may lead to other false negatives with certain validators, therefore
currently just passing a noop `DependencyResolver` keeps the status quo.
Long-term you should think about resolving those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
