stefan-egli commented on code in PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/7#discussion_r2073365735
##########
src/main/java/org/apache/sling/discovery/commons/providers/base/ViewStateManagerImpl.java:
##########
@@ -446,7 +450,20 @@ public void handleNewView(final BaseTopologyView newView) {
handleNewViewNonDelayed(newView);
}
- boolean handleNewViewNonDelayed(final BaseTopologyView newView) {
+ protected boolean handleNewViewNonDelayed(final BaseTopologyView newView) {
+ // Check if topology changes should be delayed
+ if (topologyReadinessHandler != null &&
topologyReadinessHandler.shouldTriggerTopologyChanging()) {
+ if (previousView != null) {
+ if (previousView.isCurrent()) {
+ logger.info("handleNewViewNonDelayed: would trigger
TOPOLOGY_CHANGING for current view");
+ }
+ previousView.setNotCurrent();
+ }
+ return true;
+ }
+
+ handleChanging();
+
Review Comment:
I don't see how this would achieve what it should. Can you please explain me
how this would work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
