joerghoh commented on code in PR #174: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/174#discussion_r2068191260
########## src/main/java/org/apache/sling/resourceresolver/impl/mapping/AliasHandler.java: ########## @@ -159,7 +159,11 @@ boolean usesCache() { } boolean doAddAlias(final Resource resource) { - return loadAlias(resource, this.aliasMapsMap, null, null); + if (cacheIsInitialized) { Review Comment: right now ``cacheIsInitialized`` is not marked as volatile. But with this change (or maybe even before) we should do that, as it can be accessed by multiple threads (at least that's my assumption). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org