cziegeler commented on PR #32: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/32#issuecomment-2823577320
@raducotescu yes, #31 was just a quick fix not intended to be the real solution. I think your proposal is much better, the only thing I don't like is registering a service in activate() which is usually something that should be avoided. You could avoid this by letting the factory implement that service interface directly - but that comes of course at the cost of a more bloated class. Both ways are better than what we have today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
