mirsilstan commented on PR #40: URL: https://github.com/apache/sling-org-apache-sling-event/pull/40#issuecomment-2785561910
> @mirsilstan thanks for your contribution. > > If I understand your description in [SLING-12737](https://issues.apache.org/jira/browse/SLING-12737), the code in `JobSchedulerImpl` is correct and would be able to handle the templates as intended, but not in the `JobManagerImpl`; is my understanding correct? > > I would appreciate a bit of test coverage for the code you extracted into the `PropertyNameAndOperationExtractor`class. The only reason I added the extra classes is because the code in JobManagerImpl and the code in JobSchedulerImpl is duplicated. I thought about creating a single method and reusing it in both places. However, this increases the number of changes. Hence I removed the extra classes and I changed only 2 lines which are strictly related to the bug. The code is tested in HistoryIT, if you run the test on the main branch, it will fail. Please advise if any further tests are necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
