Hi Nicola, From my perspective this should be fine. We just need a major increment of the version with the next release as this is a backwards-incompatible change. Please raise a JIRA ticket for it at https://issues.apache.org/jira/projects/SLING/issues and a PR for the splitting.
Thanks, Konrad > On 28. Mar 2025, at 11:46, Nicola Scendoni <nscend...@adobe.com.INVALID> > wrote: > > Hi all, > Currently, sling-commons-crypto contains both interfaces and implementations. > I would like to contribute to the sling-auth-oauth-client bundle, which > depends on sling-commons-crypto, but I prefer to avoid including its > implementation in our product. Ideally, sling-auth-oauth-client would depend > on a separate SPI package, which would require splitting sling-commons-crypto > into an API (SPI) and an implementation bundle. > Would you agree with this approach? > > Best regards, > > Nicola Scendoni > > [1] sling-commons-crypto > https://github.com/apache/sling-org-apache-sling-commons-crypto > [2] sling-auth-oauth-client > https://github.com/apache/sling-org-apache-sling-auth-oauth-client
