joerghoh commented on code in PR #163:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/163#discussion_r2023027917
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -115,25 +113,14 @@ public class MapEntries implements MapEntriesHandler,
ResourceChangeListener, Ex
private Collection<MapEntry> mapMaps;
- /**
- * The key of the map is the parent path, while the value is a map with
the the resource name as key and the actual aliases as values)
- */
- private Map<String, Map<String, Collection<String>>> aliasMapsMap;
-
- private final AtomicLong aliasResourcesOnStartup;
- private final AtomicLong detectedConflictingAliases;
- private final AtomicLong detectedInvalidAliases;
-
- // keep track of some defunct aliases for diagnostics (thus size-limited)
- private static final int MAX_REPORT_DEFUNCT_ALIASES = 50;
-
private final ReentrantLock initializing = new ReentrantLock();
private final StringInterpolationProvider stringInterpolationProvider;
private final boolean useOptimizeAliasResolution;
- final VanityPathHandler vph;
+ AliasHandler ah;
+ VanityPathHandler vph;
Review Comment:
NIT: what do you think about renaming these 2 to ``aliasHandler`` and
``vanityPathHandler``? A bit more descriptive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
