rzo1 commented on code in PR #178:
URL: https://github.com/apache/shiro-site/pull/178#discussion_r1113921623


##########
src/site/content/integration.adoc:
##########
@@ -129,6 +129,8 @@ from https://twitter.com/lprimak[Lenny Primak].
 +
 Integrates Jakarta EE / Java EE applications with Shiro Security, specifically 
makes Shiro Annotations work with Java EE.
 
+NOTE: This module will be inegrated directly into Shiro with version 2.0 and 
above.

Review Comment:
   `inTegrated`



##########
src/site/content/jakarta-ee.adoc:
##########
@@ -0,0 +1,387 @@
+= Apache Shiro Jakarta EE Integration
+:jbake-date: 2023-02-06 00:00:00
+:jbake-type: page
+:jbake-status: published
+:jbake-tags: documentation, jakarta-ee, integrations, web
+:idprefix:
+:icons: font
+
+Apache Shiro Jakarta EE module makes it transparent to use Shiro features in 
Jakarta EE applications
+with minimal configuration. It makes annotations such as `@RequiresRoles` 
available in Jakarta EE (CDI, EJB, etc.) code.
+
+NOTE: Jakarta EE integration is available in Shiro 2.0 or later.

Review Comment:
   Does it make sense to note which EE versions are compatible to the module? 
(as the whole thing was rebranded and we have the javax vs jakarta namespace 
thing)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@shiro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to