----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28755/ -----------------------------------------------------------
Review request for shindig. Bugs: SHINDIG-1984 https://issues.apache.org/jira/browse/SHINDIG-1984 Repository: shindig Description ------- When doing an OAUTH2 flow the first request to the service that returns the oauthApprovalUrl probably shouldn’t be cached or set in the staleResponse, because then it could possibly be used on the response for the ACTUAL request if it returns a 500. Thus an endless loop of display the approval url and making the service call. Diffs ----- trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java 1642996 trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java 1642996 Diff: https://reviews.apache.org/r/28755/diff/ Testing ------- Thanks, Doug Davies