----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28534/ -----------------------------------------------------------
Review request for shindig.
Summary (updated)
-----------------
gadget ifr servlet not able to refresh gadget xml as desired
Bugs: SHINDIG-1888
https://issues.apache.org/jira/browse/SHINDIG-1888
Repository: shindig
Description (updated)
-------
Copied from https://reviews.apache.org/r/10467/
Shindig ifr servlet entry will send the default cache control of gadget xml to
the browser as a year by default. This is not reasonable especially when gadget
xml resource server specified the cache control in its response to Shindig
server, and consumer need to dynamically create the gadget xml content.
In the HttpCache of Shindig server, the gadget xml and its response are stored.
The desired behavior would be to let the ifr servlet being able to refresh
itself so the data in HttpCache can be validated, so a refetching of gadget xml
can happen.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/GadgetXMLResponseWithCacheControl.jsp
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/gadgetCollections.json
1500152
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java
1372695
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java
1383189
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultMessageBundleFactory.java
1364210
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/Gadget.java
1364210
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
1490276
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java
1454767
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java
1372888
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java
1452056
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingResults.java
1293966
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java
1364210
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java
1490276
Diff: https://reviews.apache.org/r/28534/diff/
Testing (updated)
-------
Done
Thanks,
Jiaqing Guo
