Hi Liang, Thanks for your feedback.
I made fixes [1][2][3] for the docs you pointed out which don't have a license listed. These fixes include adding license and notice of ShardingSphere, and adding a note referencing ShardingSphere to the documentation content. For the agent module, as you mentioned I have fixed it yesterday [4]. [1] https://github.com/apache/incubator-shenyu-website/pull/485 [2] https://github.com/apache/incubator-shenyu-website/pull/486 [3] https://github.com/apache/incubator-shenyu-website/pull/487 [4] https://github.com/apache/incubator-shenyu/pull/3045 -- Zhang Yonglun Apache ShenYu (Incubating) Apache ShardingSphere zhangli...@apache.org <zhangli...@apache.org> 于2022年3月17日周四 11:07写道： > > Dear ShenYu community, > > I noticed that ShenYu agent code and community documentation were copied > directly from ShardingSphere. > > For agent module issue, ShenYu code[1] is almost same as ShardingSphere > code[2]. > I saw your PR[3], which added ShardingSphere copyright to the LICENSE and > NITICE file yesterday. > But as an incubator project, I suggest that the team design and code > according to your own original and independent ideas. > If you think the agent module is suitable for ShenYu, copy and > minor rewrite is not good enough, it is best to import it from > ShardingSphere as a library; If the agent module of ShardingSphere is not > good enough, we can discuss how to improve it in > d...@shardingsphere.apache.org or GitHub issue list. > For open source way, contribute back to upstream maybe the best ,especially > in incubator project, understanding and practicing to Apache way is import. > > For the community documentation issue, it is unnecessary copy from > ShardingSphere, please write your own documentation and follow them as your > own community way. > I saw the PR[4] and [5] rewrite the part of documentation from > ShardingSphere. The PR[4] had merged half year ago, which means that ShenYu > use ShardingSphere's documentation early. > However, there are still many documents copied directly from > ShardingSphere. Please fix them as well. > The documentation which copied from ShardingSphere are: > Shenyu [6] copied from ShardingSphere [7] > Shenyu [8] copied from ShardingSphere [9] > Shenyu [10] copied from ShardingSphere [11] > Shenyu [12] copied from ShardingSphere [13] > Shenyu [14] copied from ShardingSphere [15] > Shenyu [16] copied from ShardingSphere [17] > Shenyu [18] copied from ShardingSphere [19] > Shenyu [20] copied from ShardingSphere [21] > Shenyu [22] copied from ShardingSphere [23] > > > [1] https://github.com/apache/incubator-shenyu/tree/master/shenyu-agent > [2] > https://github.com/apache/shardingsphere/tree/master/shardingsphere-agent > [3] https://github.com/apache/incubator-shenyu/pull/3045 > [4] > https://github.com/apache/incubator-shenyu-website/commit/c6f1971d412b267a06dde973df4f6892b6685c1a > [5] > https://github.com/apache/incubator-shenyu-website/commit/365c1edb17d75e3d0dbc11633dc8234f75a3bea4 > [6] https://shenyu.apache.org/community/contributor > [7] https://shardingsphere.apache.org/community/en/contribute/contributor/ > [8] https://shenyu.apache.org/community/release-guide > [9] https://shardingsphere.apache.org/community/en/contribute/release/ > [10] https://shenyu.apache.org/community/vote-committer > [11] https://shardingsphere.apache.org/community/en/contribute/vote/ > [12] https://shenyu.apache.org/community/two-fa > [13] https://shardingsphere.apache.org/community/en/contribute/2fa/ > [14] https://shenyu.apache.org/zh/community/subscribe-email > [15] https://shardingsphere.apache.org/community/cn/contribute/subscribe/ > [16] https://shenyu.apache.org/zh/community/contributor > [17] https://shardingsphere.apache.org/community/cn/contribute/contributor/ > [18] https://shenyu.apache.org/zh/community/release-guide > [19] https://shardingsphere.apache.org/community/cn/contribute/release/ > [20] https://shenyu.apache.org/zh/community/vote-committer > [21] https://shardingsphere.apache.org/community/cn/contribute/vote/ > [22] https://shenyu.apache.org/zh/community/two-fa > [23] https://shardingsphere.apache.org/community/cn/contribute/2fa/ > > ------------------ > > Sincerely, > Liang Zhang (John) > Apache ShardingSphere
