Thanks a lot. It seems like SkyWalking eyes is more strong than rat.I'll take a look.
-- Zhang Yonglun Apache ShenYu (Incubating) Apache ShardingSphere Sheng Wu <wush...@apache.org> 于2021年7月30日周五 下午6:29写道： > Forward to Shenyu dev list > SkyWalking eyes tool is doing header checking mostly through GHA. > You could take a look and retry. > > https://github.com/apache/skywalking-eyes > > Zhang Yonglun <zhangyong...@apache.org>于2021年7月30日 周五下午3:45写道： > > > Hi Justin, > > > > Thanks for your help. > > > > > This file [1] has an incorrect header and may be from another project. > > Where sis this code come from? > > This file contains some very simple test cases, we assume that they are > not > > from another project, but just added a wrong license header. We are > trying > > to contact the contributor who contribute this file to make things clear. > > Before he/she respond, we'd like to remove this file to avoid issues. > > > > BTW, we check the licenses via apache-rat-plugin, but it didn't prompt > this > > file has a problem, even the header is not right. Can you give us some > > suggestions that how you find out this problem? So that we can use the > same > > method to check all the files again before start the next round vote. > > > > > This file [2] may incorrectly have an ASF header and contains 3rd party > > code not mentioned in LICENSE. Looks like there may be other 3rd party > code > > (from the same project) in other files as well? > > Yes, the other file contains 3rd party code is > > > > > ./apache-shenyu-incubating-2.4.0-src/shenyu-admin/src/main/resources/static/index.40aac744.js > > All the two files (index.6e738f45.css and index.40aac744.js) are built > from > > shenyu-dashboard, they should not appear in the src release package. We > > will exclude these two files from the src package. > > > > After resolve these two problems, we can start the round 2 vote process. > > > > Thanks. > > > > > > -- > > > > Zhang Yonglun > > Apache ShenYu (Incubating) > > Apache ShardingSphere > > > > > > > > Justin Mclean <jus...@classsoftware.com> 于2021年7月30日周五 下午3:16写道： > > > > > Hi, > > > > > > Look like I hit send too soon there: > > > "Sorry but it -1 binding form me. LICENSE is missing 3rd party license > > > information” > > > > > > Thanks, > > > Justin > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > -- > Sheng Wu 吴晟 > > Apache SkyWalking > Apache Incubator > Apache ShardingSphere, ECharts, DolphinScheduler podlings > Zipkin > Twitter, wusheng1108 >
