Zhangyx39 commented on a change in pull request #982: SAMZA-2153: Implement to
Config for TableRetryPolicy
URL: https://github.com/apache/samza/pull/982#discussion_r272306302
##########
File path:
samza-api/src/main/java/org/apache/samza/table/retry/TableRetryPolicy.java
##########
@@ -256,4 +265,30 @@ public BackoffType getBackoffType() {
public RetryPredicate getRetryPredicate() {
return retryPredicate;
}
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public Map<String, String> toConfig(Config jobConfig, Config tableConfig) {
+ final Gson gson = new
GsonBuilder().excludeFieldsWithModifiers(Modifier.TRANSIENT,
Modifier.STATIC).create();
+ return Collections.singletonMap(String.format("%s.%s", getTableId(),
this.getClass().getCanonicalName()),
Review comment:
We can do "tables.<tableId>.<className>" to keep the similar format and
avoid collision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
