mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272007958
########## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationTest.java ########## @@ -50,15 +50,18 @@ import org.apache.samza.test.table.TestTableData; import org.junit.Assert; import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import static org.apache.samza.test.controlmessages.TestData.PageView; public class StreamApplicationIntegrationTest { + private static final Logger LOG = LoggerFactory.getLogger(StreamApplicationIntegrationTest.class); private static final String[] PAGEKEYS = {"inbox", "home", "search", "pymk", "group", "job"}; @Test - public void testStatefulJoinWithLocalTable() { + public void testStatefulJoinWithLocalTable() throws InterruptedException { Review comment: Why do you need this method to throw InterruptedException? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services