[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

[GitBox]

sborya commented on a change in pull request #984: Samza 2116: Making sink, 
sendTo(table), sendTo(stream) non-terminal
URL: https://github.com/apache/samza/pull/984#discussion_r271997395
 
 

 ##########
 File path: 
samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationTest.java
 ##########
 @@ -149,21 +161,30 @@ public void describe(StreamApplicationDescriptor 
appDescriptor) {
       KafkaInputDescriptor<KV<String, TestTableData.Profile>> profileISD =
           ksd.getInputDescriptor("Profile", KVSerde.of(new StringSerde(), new 
JsonSerdeV2<>()));
 
-      appDescriptor
-          .getInputStream(profileISD)
-          .map(m -> new KV(m.getValue().getMemberId(), m.getValue()))
-          .sendTo(table);
-
       KafkaInputDescriptor<KV<String, TestTableData.PageView>> pageViewISD =
           ksd.getInputDescriptor("PageView", KVSerde.of(new StringSerde(), new 
JsonSerdeV2<>()));
       KafkaOutputDescriptor<TestTableData.EnrichedPageView> 
enrichedPageViewOSD =
           ksd.getOutputDescriptor("EnrichedPageView", new JsonSerdeV2<>());
 
+      appDescriptor.getInputStream(profileISD)
+          .map(m -> new KV(m.getValue().getMemberId(), m.getValue()))
+          .sendTo(table)
+          .sink((kv, collector, coordinator) -> {
 
 Review comment:
   should you test that sink() returns message stream?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services