shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r269269232
########## File path: gradle/dependency-versions.gradle ########## @@ -34,7 +34,7 @@ jodaTimeVersion = "2.2" joptSimpleVersion = "3.2" junitVersion = "4.12" - kafkaVersion = "0.11.0.2" + kafkaVersion = "2.0.1" Review comment: Discussed offline. Since we're bumping up kafka-client version to 2.0, it would be better to run the perf tests. If possible try running [kafka-read-write-perf](https://github.com/apache/samza/blob/master/samza-test/src/main/config/perf/kafka-read-write-performance.properties) test before landing this patch and verify there's no performance degradation(in terms of QPS/poll-latency). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
