cameronlee314 commented on a change in pull request #955: SAMZA-2131: [Scala
cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala
to Java
URL: https://github.com/apache/samza/pull/955#discussion_r268763050
##########
File path: samza-core/src/main/java/org/apache/samza/config/SystemConfig.java
##########
@@ -33,27 +34,35 @@
/**
* a java version of the system config
*/
-public class JavaSystemConfig extends MapConfig {
- public static final String SYSTEM_PREFIX = "systems.";
- public static final String SYSTEM_FACTORY_SUFFIX = ".samza.factory";
- public static final String SYSTEM_FACTORY_FORMAT = SYSTEM_PREFIX + "%s" +
SYSTEM_FACTORY_SUFFIX;
- private static final String SYSTEM_DEFAULT_STREAMS_PREFIX_FORMAT =
SYSTEM_PREFIX + "%s" + ".default.stream.";
+public class SystemConfig extends MapConfig {
+ public static final String SYSTEMS_PREFIX = "systems.";
Review comment:
I agree with that in general. Unfortunately, in this case, some of the
variables depend on each other (e.g. a public var depends on a private var, and
vice versa), so there is a certain ordering required, so they need to be mixed
up some.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
