shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java URL: https://github.com/apache/samza/pull/955#discussion_r268415931
########## File path: samza-core/src/main/scala/org/apache/samza/util/CoordinatorStreamUtil.scala ########## @@ -66,9 +66,9 @@ object CoordinatorStreamUtil { */ def getCoordinatorSystemFactory(config: Config) = { val systemName = config.getCoordinatorSystemName - val systemFactoryClassName = config - .getSystemFactory(systemName) - .getOrElse(throw new SamzaException("Missing configuration: " + SystemConfig.SYSTEM_FACTORY format systemName)) + val systemConfig = new SystemConfig(config); Review comment: Minor: Remove the unnecessary semicolon at the end. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services