shanthoosh opened a new pull request #959: SAMZA-2133: Fix the TestKeyValuePerformance test. URL: https://github.com/apache/samza/pull/959 Running the TestJeyValuePerformance test results in the following failure: ``` 2019-03-19 11:16:36.713 [main] TestKeyValuePerformance$ [INFO] Running test: rocksdb-write-performance Exception in thread "main" java.lang.IllegalArgumentException: Job name is not defined in configuration at org.apache.samza.context.JobContextImpl.fromConfigWithDefaults(JobContextImpl.java:49) at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2$$anonfun$apply$1.apply$mcVI$sp(TestKeyValuePerformance.scala:126) at scala.collection.immutable.Range.foreach$mVc$sp(Range.scala:160) at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2.apply(TestKeyValuePerformance.scala:114) at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2.apply(TestKeyValuePerformance.scala:112) at scala.collection.TraversableLike$WithFilter$$anonfun$foreach$1.apply(TraversableLike.scala:733) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48) at scala.collection.TraversableLike$WithFilter.foreach(TraversableLike.scala:732) at org.apache.samza.test.performance.TestKeyValuePerformance$.invokeTest(TestKeyValuePerformance.scala:112) at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$main$1.apply(TestKeyValuePerformance.scala:80) at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$main$1.apply(TestKeyValuePerformance.scala:77) at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33) at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:186) at org.apache.samza.test.performance.TestKeyValuePerformance$.main(TestKeyValuePerformance.scala:77) at org.apache.samza.test.performance.TestKeyValuePerformance.main(TestKeyValuePerformance.scala) :samza-shell:kvPerformanceTest FAILED ``` Through SAMZA-1714, we added a verification in`JobContextImpl` to validate the presence of the `JobId`, `JobName` in configuration. JobId, JobName configurations are not populated in config of `TestKeyValuePerformance` before launching the test. The fix is to add the two configuration `JobId`, `JobName` in the configuration before launching the test.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
