lhaiesp commented on a change in pull request #950: SAMZA-2126: Bug fixes for
batch-mode generated stream specs
URL: https://github.com/apache/samza/pull/950#discussion_r264500671
##########
File path:
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala
##########
@@ -106,8 +106,8 @@ class KafkaSystemFactory extends SystemFactory with
Logging {
if (appConfig.getAppMode == ApplicationMode.BATCH) {
val streamConfig = new StreamConfig(config)
streamConfig.getStreamIds().filter(streamConfig.getIsIntermediateStream(_)).map(streamId
=> {
+ // only the override here
val properties = new Properties()
- properties.putAll(streamConfig.getStreamProperties(streamId))
Review comment:
It's not obvious to me how this is different from the
kafkaSpec.getProperties(). Will follow up with you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
