lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531:
Support run.id in standalone for batch processing.
URL: https://github.com/apache/samza/pull/938#discussion_r264492678
##########
File path:
samza-azure/src/main/java/org/apache/samza/coordinator/AzureCoordinationUtils.java
##########
@@ -52,6 +52,16 @@ public DistributedLockWithState getLockWithState(String
lockId) {
return new AzureLock(blob);
}
+ @Override
+ public DistributedReadWriteLock getReadWriteLock(String lockId) throws
UnsupportedOperationException {
Review comment:
getReadWriteLock() is used in LocalApplicationRunner (LAR) when
app.mode=BATCH. If we throw an exception here instead of returning null, none
of the standalone deployments for BATCH mode using Azure will even work.
Currently, no run.id is generated for standalone (for both ZK and Azure) and
thus, if we return null here instead of an exception, it would revert to the
existing behavior until we support run.id for Azure.
Would it help if we log a warning explaining that run.id will not be
generated (meaning previous state will be reused) and this batch job wont
starting with fresh state?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
