prateekm commented on a change in pull request #947: SAMZA-2120: Enable custom
handling of ConsumerRecords consumed by Kafka
URL: https://github.com/apache/samza/pull/947#discussion_r264352561
##########
File path:
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaConsumerProxy.java
##########
@@ -51,7 +53,7 @@
* This class is not thread safe. There will be only one instance of this
class per KafkaSystemConsumer object.
* We still need some synchronization around kafkaConsumer. See pollConsumer()
method for details.
*/
-class KafkaConsumerProxy<K, V> {
+public class KafkaConsumerProxy<K, V> {
Review comment:
Do the K, V type parameters matter for this class (and the underlying
KafkaConsumer)?. If not, maybe remove for simplicity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
