vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r260917527
########## File path: samza-core/src/main/java/org/apache/samza/clustermanager/HostAwareContainerAllocator.java ########## @@ -81,13 +87,27 @@ public void assignResourceRequests() { if (expired) { updateExpiryMetrics(request); - if (resourceAvailableOnAnyHost) { - log.info("Request for container: {} on {} has expired. Running on ANY_HOST", request.getContainerID(), request.getPreferredHost()); - runStreamProcessor(request, ResourceRequestState.ANY_HOST); + + if (standbyContainerManager.isPresent()) { Review comment: what if standby is not enabled? the current behavior is to issue any_host request. is that changed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services