rmatharu commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r260911400
########## File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java ########## @@ -484,5 +497,13 @@ private String getPendingContainerId(String resourceId) { return null; } + private void handleContainerStop(String containerID, String resourceID, String preferredHost, int exitStatus) { + if (standbyContainerManager.isPresent()) { + standbyContainerManager.get().handleContainerStop(containerID, resourceID, preferredHost, exitStatus, containerAllocator); Review comment: The HACA needs/has a handle on standbyContainerManager (e.g., to handle expired requests), ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services