dnishimura commented on a change in pull request #918: SAMZA-2094: Implement
the StartpointVisitor for the KafkaSystemConsumer.
URL: https://github.com/apache/samza/pull/918#discussion_r260539371
##########
File path:
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala
##########
@@ -154,6 +164,11 @@ class SystemConsumers (
metrics.setUnprocessedMessages(() => totalUnprocessedMessages)
def start {
+ for ((systemStreamPartition, offset) <- sspToRegisteredOffsets.asScala) {
Review comment:
Just wondering why is this necessary? When would consumers restart multiple
times and seek to the last registered offset? Is it some error scenario you're
handling?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
