rmatharu commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r260086115
########## File path: samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala ########## @@ -656,13 +593,11 @@ object SamzaContainer extends Logging { storageManager = storageManager, tableManager = tableManager, reporters = reporters, - systemStreamPartitions = taskSSPs, + systemStreamPartitions = taskSSPs -- taskSideInputSSPs, Review comment: Lets do it separately under https://issues.apache.org/jira/browse/SAMZA-2112 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services