GitHub user weiqingy opened a pull request:

    https://github.com/apache/samza/pull/845

    Supports environment variables for SqlExecutors. 

    ## What changes were proposed in this pull request?
    1. User can now set environment variables for the shell itself and for any 
SqlExecutor, by executing the 'SET' command in the shell or by using a 
configuration file. User can also choose to use any SqlExecutor they want in 
the same way. 
    
    2. Refine the abstraction of environment variables. New interfaces and 
abstract classes are added so the shell itself and any SqlExecutor can now give 
a specification about what variables they support, what the possible values 
are, the default value, and whether they accept unknown variables or not. The 
shell and SqlExecutors now handle environment variables in a consistent way.
    
    ## How was this patch tested?
    Tested in Samza SQL shell.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/weiqingy/samza samza-shell-setdev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/845.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #845
    
----
commit eda1f9219dd896b164fdadd03c75919c4d5936cb
Author: Weiqing Yang <yangweiqing001@...>
Date:   2018-12-05T07:16:02Z

    Supports environment variables for SqlExecutors. Also refines the way of 
managing environment variables and configurations.

----


---

Reply via email to