GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/790

    [WIP] SAMZA-1973: Unify the TaskNameGrouper interface for yarn and 
standalone.

    
    This patch consists of the following changes:
    * Unify the different methods present in the TaskNameGrouper interface. 
This will enable us to have a single interface method usable for both the yarn 
and standalone models.
    * Generate locationId aware task assignment to processors in standalone.
    * Move the task assignment persistence logic from a custom 
`TaskNameGrouper` implementation to `JobModelManager`, so that this works for 
any kind of custom group.
    * General code clean up in `JobModelManager`,  `TaskAssignmentManager` and 
in other samza internal classes.
    * Read/write taskLocality of the processors in standalone. 
    
    Testing: 
    * Fixed the existing unit-tests due to the changes. 
    * Added new unit tests for the functionality changed added as a part of 
this patch. 
    * Tested this patch with a sample job from `hello-samza` project and 
verified that it works as expected.
    
    Please refer to 
[SEP-11](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75957309)
 for more details.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza task_name_grouper_changes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/790.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #790
    
----
commit 4f72a5c9ed2bf14296b84449df09353eaa3b469c
Author: Shanthoosh Venkataraman <spvenkat@...>
Date:   2018-09-22T02:10:22Z

    [WIP] SAMZA-1973: Unify the TaskNameGrouper interface for yarn and 
standalone.

----


---

Reply via email to