----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68867/#review209142 -----------------------------------------------------------
Ship it! One comment. All the configs in this sample job are provided in code and removed from the configs. We need to clarify that users still can use configs and the values of the configs will override values given in the code (to allow redeployments without recompilation). - Boris Shkolnik On Sept. 28, 2018, 11:55 p.m., Xinyu Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68867/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2018, 11:55 p.m.) > > > Review request for samza, Boris Shkolnik and Prateek Maheshwari. > > > Repository: samza-hello-samza > > > Description > ------- > > Update hell0-samza with latest code > > > Diffs > ----- > > build.gradle 9d1f5433afc548ee19b00c0e0e2e73e7963d25ef > src/main/config/pageview-adclick-joiner.properties > eba7b0b6efc86869dbdf9402ae069550ed4c1723 > src/main/config/pageview-filter.properties > 331ee1a1f1315c13aa955353795853eca792d669 > src/main/config/pageview-profile-table-joiner.properties > 7cec6013e744042295568cef17928321abf95b35 > src/main/config/pageview-sessionizer.properties > 420cdde0d2d82f22daafc49b7428040a7dcd1eef > src/main/config/stock-price-table-joiner.properties > f9bd684ed3601ba887b48c87c070f31c8b137f8e > src/main/config/tumbling-pageview-counter.properties > b58dbe9a951a1ec1978a745efdd43e0f9fe87483 > src/main/config/wikipedia-application-local-runner.properties > b770f1317dfd61b33122c71127ba8163135a26e5 > src/main/config/wikipedia-application.properties > 841fcc5a3ca6b5e52c82e717fb7baa1e380d134f > src/main/java/samza/examples/azure/AzureApplication.java > 9f565fe47373c5bb054cfcc1ccc00e54111d786e > src/main/java/samza/examples/azure/AzureZKLocalApplication.java > 3d4f8b05cd1405070448c7598afa2712bb2db13d > src/main/java/samza/examples/cookbook/PageViewAdClickJoiner.java > f6c3810ad59532563994ff344952490369c87350 > src/main/java/samza/examples/cookbook/PageViewFilterApp.java > a2accfdd8fee6033133e77e74fa8c6fd8de186c5 > src/main/java/samza/examples/cookbook/PageViewProfileTableJoiner.java > 86deb614cc7bf9720df86e9d9f49bb4613ce1384 > src/main/java/samza/examples/cookbook/PageViewSessionizerApp.java > 2bcd9f5b8f8e14e451451a12b627e189ad673288 > src/main/java/samza/examples/cookbook/StockPriceTableJoiner.java > cb735d284f82b67f01f797c2ede2c130b80eb047 > src/main/java/samza/examples/cookbook/TumblingPageViewCounterApp.java > acf1411af7d951081ad988c92822fde2b140608d > > src/main/java/samza/examples/wikipedia/application/WikipediaApplication.java > 032608f4f1f2525c0d5598ea80b84ed4d40f6f7e > > src/main/java/samza/examples/wikipedia/application/WikipediaZkLocalApplication.java > 51dd28f69b146962b2853d2426e153e13a6ab1e6 > src/main/java/samza/examples/wikipedia/model/WikipediaParser.java > 93479626afa0fb9f8a230fa755e8f30fdbc57563 > src/main/java/samza/examples/wikipedia/system/WikipediaInputDescriptor.java > PRE-CREATION > > src/main/java/samza/examples/wikipedia/system/WikipediaSystemDescriptor.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68867/diff/2/ > > > Testing > ------- > > Only tested the high-level wikipedia example for now. I will keep testing the > rest of it in the next few days. Commit the change for now to unblock others > to test. > > > Thanks, > > Xinyu Liu > >
