GitHub user weisong44 opened a pull request:
https://github.com/apache/samza/pull/636
Reuse table instances in TableManager
We currently are invoking TableProvider.getTable() when
TableManager.getTable(tableId) is invoked every time, this would in turn cause
a new table instance being created. The assumption used so far is that end user
would cache table instances, which is not always true. Therefore we should
reuse table instance created earlier in TableManager.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weisong44/samza fix_table_manager
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/636.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #636
----
commit 3f7ed71f8f5d6efe3567f039734ac96bb12679b6
Author: Wei Song <wsong@...>
Date: 2018-07-25T01:34:06Z
Added self to committer list
commit 5cbf9af9c12b96c5773a37274538f8baea8347e1
Author: Wei Song <wsong@...>
Date: 2018-08-03T20:38:41Z
Merge remote-tracking branch 'upstream/master'
commit a15a7c9a231adcc1b441351963e15a7855ea5879
Author: Wei Song <wsong@...>
Date: 2018-08-06T18:49:30Z
Merge remote-tracking branch 'upstream/master'
commit aae0f380e49950bc36a18e34d08041d554fc13a7
Author: Wei Song <wsong@...>
Date: 2018-08-16T17:50:45Z
Merge remote-tracking branch 'upstream/master'
commit 0440f75fcd16061d8ff87e775d4a1e731936ece0
Author: Wei Song <wsong@...>
Date: 2018-08-20T18:42:56Z
Merge remote-tracking branch 'upstream/master'
commit 4782c61df5eb046a57c0401ab94c1d88dc6ba0a7
Author: Wei Song <wsong@...>
Date: 2018-08-21T19:47:29Z
Merge remote-tracking branch 'upstream/master'
commit f28b491de20cf18357f9f92b780fb3eba52f6301
Author: Wei Song <wsong@...>
Date: 2018-08-23T22:22:40Z
Merge remote-tracking branch 'upstream/master'
commit df2f8d7b6ebc714a42376d98a45db20343f0a0fd
Author: Wei Song <wsong@...>
Date: 2018-08-27T16:10:59Z
Merge remote-tracking branch 'upstream/master'
commit de708f5e93bcdd352137db8c570469dd6a657ee5
Author: Wei Song <wsong@...>
Date: 2018-09-05T19:17:04Z
Merge remote-tracking branch 'upstream/master'
commit 5156239155e0a010242fd5f7d96de1892494e376
Author: Wei Song <wsong@...>
Date: 2018-09-11T22:27:45Z
Merge remote-tracking branch 'upstream/master'
commit 839bf76d8cc95738c760204f8082923444774c80
Author: Wei Song <wsong@...>
Date: 2018-09-12T00:36:10Z
Added caching for table instances in TableManager
----
---
