GitHub user weisong44 opened a pull request:

    https://github.com/apache/samza/pull/560

    Fixed failed unit tests in TestCachingTable

    This is due to the recent refactoring of table metrics, for some reason 
running build locally didn't catch these failed tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/weisong44/samza table-metrics-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/560.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #560
    
----
commit e4cfad7797c7dd526384b07cba0980baaeb4d093
Author: Wei Song <wsong@...>
Date:   2018-06-15T04:50:35Z

    Refactored metrics for table API and added missing metrics to local, remote 
and caching tables.

commit 47215f77de27ef681a3641e61254977fca56ee4f
Author: Cameron Lee <calee@...>
Date:   2018-06-13T23:04:02Z

    SAMZA-1670: When fetching a newest offset for a partition, also prefetch 
and cache the newest offsets for other partitions on the container
    
    Author: Cameron Lee <ca...@linkedin.com>
    
    Reviewers: Jagadish <jagad...@apache.org>
    
    Closes #520 from cameronlee314/partition_metadata

commit 85bdf1570706f70f1a7b63304a3317f49258b53f
Author: Cameron Lee <calee@...>
Date:   2018-06-13T23:12:44Z

    SAMZA-1709: Use lazy creation for SystemAdmins in ApplicationRunners
    
    An instance of SystemAdmins is created when instantiating any 
AbstractApplicationRunner, but the SystemAdmins is only actually needed for 
some of the methods for some of the runners. For example, 
LocalApplicationRunner.kill does not need SystemAdmins, and 
LocalContainerRunner does not need SystemAdmins for anything.
    Doing lazy instantiation allows us to more easily manage the SystemAdmins 
lifecycle, since it removes the need to add lifecycle hooks for the 
ApplicationRunner.
    This also fixes the lifecycle management for SystemAdmins in 
ApplicationRunners.
    
    Author: Cameron Lee <ca...@linkedin.com>
    
    Reviewers: Xinyu Liu <xi...@apache.org>
    
    Closes #512 from cameronlee314/runnner_system_admins

commit 4b6e2ed19ff80715a564420f8c1f2def9b80a7a7
Author: Ray Matharu <rmatharu@...>
Date:   2018-06-14T04:01:53Z

    Add a new ListGauge metric-type
    
    This PR introduces a ListGauge type,
    A subsequent PR: https://github.com/apache/samza/pull/543 shows how this 
issued in conjunction with a diagnostics appender for error-tracking and 
dumpting to kafka via SnapshotReporter.
    
    Author: Ray Matharu <rmath...@linkedin.com>
    
    Reviewers: Jagadish <jagad...@apache.org>, Cameron Lee <ca...@linkedin.com>
    
    Closes #541 from rayman7718/listgauge

commit 554c7006133cae7c32739654b19dd5b5503cca08
Author: Jagadish <jvenkatraman@...>
Date:   2018-06-14T21:04:53Z

    SAMZA-1747: Add metric to measure effectiveness of host-affinity
    
    We require visibility into how effectively host-affinity performs. The goal 
is to help easily answer the following questions.
    - How effectively is YARN matching my preferred-host requests
    - When does Samza fallback to abandoning locality and issuing any-host 
requests?
    
    design doc: 
https://docs.google.com/document/d/1oeNKDnG4JIGT2846us-jpnGW_RUjMjPIKDeEUlE_-jg/edit#
    
    Author: Jagadish <jvenkatra...@linkedin.com>
    
    Reviewers: Prateek M<pmahe...@linkedin.com>
    
    Closes #553 from vjagadish1989/hostaffinity-metrics

commit 5d9e6f02530cbe85dea32ebb6d0018b1d44ec2f3
Author: Wei Song <wsong@...>
Date:   2018-06-15T23:12:57Z

    Updated based on review comments

commit 9ad72f32a7bf23d377f17f9c769615013f1cffc8
Author: Wei Song <wsong@...>
Date:   2018-06-22T20:18:58Z

    Merge branch 'master' into table-metrics

commit 2ad1dc8364228267ba15f917d9776e07fb099db7
Author: Wei Song <wsong@...>
Date:   2018-06-22T20:27:01Z

    Fixed failed unit test in TestCachingTable

----


---

Reply via email to