GitHub user cameronlee314 opened a pull request:
https://github.com/apache/samza/pull/512
SAMZA-1709 : Use lazy creation for SystemAdmins in ApplicationRunners
An instance of SystemAdmins is created when instantiating any
AbstractApplicationRunner, but the SystemAdmins is only actually needed for
some of the methods for some of the runners. For example,
LocalApplicationRunner.kill does not need SystemAdmins, and
LocalContainerRunner does not need SystemAdmins for anything.
Doing lazy instantiation allows us to more easily manage the SystemAdmins
lifecycle, since it removes the need to add lifecycle hooks for the
ApplicationRunner.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cameronlee314/samza runnner_system_admins
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/512.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #512
----
commit bcf3603514bf2d36cee0e231befe863d777a1910
Author: Cameron Lee <calee@...>
Date: 2018-05-09T20:26:25Z
SAMZA-1709 : Use lazy creation for SystemAdmins in ApplicationRunners
----
---
