GitHub user xinyuiscool opened a pull request:
https://github.com/apache/samza/pull/277
SAMZA-1386: Inline End-of-stream and Watermark logic inside OperatorImpl
This patch contains the following changes:
1. Refactor watermark and end-of-stream logic. The aggregation/handling has
been moved from WatermarkManager/EndOfStreamManager to be inline inside
OperatorImpl. This is for keeping the logic in one place.
2. Now subclass of OperatorImpl will override handleWatermark() to do its
specific handling, such as fire trigger.
3. Add emitWatermark() in OperatorImpl so subclass can call it to emit
watermark upon receiving a message or watermark.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xinyuiscool/samza SAMZA-1386
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #277
----
commit 580dc892b54e772472c5668624a753a757e54fd2
Author: Xinyu Liu <xi...@xiliu-ld.linkedin.biz>
Date: 2017-08-10T01:25:01Z
Refactor end-of-stream
commit 368db3560d7f443c517b66ffb6bcf596cf5bcf07
Author: Xinyu Liu <xi...@xiliu-ld.linkedin.biz>
Date: 2017-08-15T00:33:19Z
Refactor end-of-stream
commit f983dba929bb2bc855f07c904735d6e0089d6eb2
Author: Xinyu Liu <xi...@xiliu-ld.linkedin.biz>
Date: 2017-08-16T00:26:18Z
Refactor watermark
commit fab42f82d04c6cb7bdaf4f7ed1c1dd36f7ce4134
Author: Xinyu Liu <xi...@xiliu-ld.linkedin.biz>
Date: 2017-08-16T21:40:13Z
Add unit tests for watermarks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
