GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/104

    Remove coordinatorStreamSystemConsumer.stop from JobModelManager.

    One BrokerProxy is created for a kafkaCluster (Host, Port) combination and 
shared by all KafkaSystemConsumer instances. BrokerProxy for each (Host, Port) 
is stopped in KafkaSystemConsumer.stop and  not recreated during successive 
KafkaSystemConsumer.create calls.
    
    CoordinatorSystemConsumer.stop flow triggers this 
sequence(KafkaSystemConsumer.stop) 
    and shutsdown the broker for coordinatorStream kafka cluster (Host, Port). 
    
    Altering the KafkaSystemConsumer.create logic to recreate BrokerProxy
    for each (Host, Port) impacts other portions of KafkaSystemConsumer, hence 
for now 
    this patch removes the coordinatorSystemConsumer.stop call from finally 
block
    in classes JobModelManager and SamzaTaskProxy.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
    
----
commit 6632541780c8ebc1e811743cddba8e516391608e
Author: Shanthoosh Venkataraman <svenkatara...@linkedin.com>
Date:   2017-03-30T01:17:06Z

    Remove coordinatorStreamSystemConsumer.stop from JobModelManager.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to