----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/#review156078 -----------------------------------------------------------
Ship it! I'll try commiting it once the patch is posted on a JIRA - Jake Maes On Nov. 16, 2016, 5:44 a.m., Shanthoosh Venkataraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53297/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 5:44 a.m.) > > > Review request for samza and Jake Maes. > > > Repository: samza > > > Description > ------- > > This patch aims at enabling users to define custom reporters to send metrics > from the monitors. Configurations required for the definition of the metrics > reporters follows the same convention as of the samza jobs. > ==== Updated diff ===== > Adding monitorName in MonitorFactory getMonitor method to enable creation of > namespaced metrics from each of the monitor. monitorName can be used by > MonitorFactory implementations in the metrics that are created and reported > from them. > > > Diffs > ----- > > docs/learn/documentation/versioned/rest/monitors.md > 46678bbe5fed99f767c3324dc9578ee1a64cec66 > samza-core/src/main/java/org/apache/samza/util/MetricsReporterLoader.java > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > e0468ee89c89fd720834461771ebb36475475bcb > > samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala > f24beb1e099dd44b15b475e0a4a7f70560c6965e > samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java > c38a5d8f737ee5cf39a4876697025fa9cd300bff > samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java > dcf9e5734b1d97e37e4fd0e89cc7f525a37a0d65 > samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java > 754ad82af9ef0f2334ec629160be39d183df1b38 > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java > 2a3e83a24a5343bb53b93fc9d0a647c1b253714b > samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java > e75f4946f38523284921798578f2a3db9c02f599 > > samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java > ccc534efc8594837f83b9126ca3d4ee22d8fbb05 > > samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java > af414b46dc5c2ff1579deb2c247cd94388a0b3ea > > samza-rest/src/test/java/org/apache/samza/monitor/mock/MockMonitorFactory.java > 5b19001eb5db51b6cc4440cf74be92f285ab0209 > samza-rest/src/test/java/org/apache/samza/rest/TestSamzaRestService.java > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala > 8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca > > Diff: https://reviews.apache.org/r/53297/diff/ > > > Testing > ------- > > Unit tests are done to verify the intended functionality. > > > Thanks, > > Shanthoosh Venkataraman > >
