----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53326/#review154458 -----------------------------------------------------------
Ship it! Ship It! - Fred Ji On Nov. 1, 2016, 6:40 a.m., Jagadish Venkatraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53326/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 6:40 a.m.) > > > Review request for samza, Jake Maes, Yi Pan (Data Infrastructure), Prateek > Maheshwari, and Xinyu Liu. > > > Repository: samza > > > Description > ------- > > Refactor API classes from Samza-Operator/operator into samza-api. > > - Programmers write code against classes on samza-api, and it would be nice > to not have a dependency on samza-operator (when defining the transform logic > for the operator). > - For split-deployment to be effective, it'd be nice to independently evolve > samza-operator components. > - Fixed checkstyle issues and formating. > > Note: There are a couple of bugs that I found in the operator logic > (SAMZA-914/915). They are intentionally kept out of the scope this RB > > > Diffs > ----- > > build.gradle aeefd1cfd049efa37d20e12e34232600ae6bd127 > checkstyle/checkstyle.xml 770b5e7f7a091198bbf53b3908600f9ac0caa4c7 > gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf > gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 > gradle/wrapper/gradle-wrapper.properties > 78596c0ebdd585e2d674cbcec930d0a8a2a08e74 > gradlew 91a7e269e19dfc62e27137a0b57ef3e430cee4fd > samza-api/src/main/java/org/apache/samza/storage/StorageEngineFactory.java > 963ccf2b6222f0fee00705923d921f91ed481fbc > > samza-core/src/test/java/org/apache/samza/coordinator/stream/MockCoordinatorStreamWrappedConsumer.java > 429573b480112c7491303dc410d78f37a308c4a7 > > samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamSystemConsumer.java > 0e73e18bd55e343e1a5122be7e8f3c666b797dc5 > > samza-operator/src/main/java/org/apache/samza/operators/api/MessageStream.java > b5e1028662a67e6248722ef7c842c565fef7a458 > > samza-operator/src/main/java/org/apache/samza/operators/api/MessageStreams.java > 59dd91c2f537828640b1ede6b6366e37f6b5c63b > > samza-operator/src/main/java/org/apache/samza/operators/api/TriggerBuilder.java > fc3ea37563ded2fcceeb332b0edfef45208bb9bb > > samza-operator/src/main/java/org/apache/samza/operators/api/WindowState.java > 402cc42f63bad0c8745c6a480b03769f92053622 > samza-operator/src/main/java/org/apache/samza/operators/api/Windows.java > e557b34c25ff425385aedae24bad6bb89ee03a30 > > samza-operator/src/main/java/org/apache/samza/operators/api/data/IncomingSystemMessage.java > ba74618961d3ea53ad455de3263c59c0ca2a0fa7 > > samza-operator/src/main/java/org/apache/samza/operators/api/data/InputSystemMessage.java > c7860254e38a897e42e00b60111526db0f7510ea > > samza-operator/src/main/java/org/apache/samza/operators/api/data/LongOffset.java > f059b337e299aab07c85af9866371c87fcf59786 > > samza-operator/src/main/java/org/apache/samza/operators/api/data/Message.java > 9b53b4582ed12fa7d9948ff756ed9d0a4b38e280 > > samza-operator/src/main/java/org/apache/samza/operators/api/data/Offset.java > 0fac2c0123b133566630bdf11e9b1c00a207bd2e > > samza-operator/src/main/java/org/apache/samza/operators/api/internal/Operators.java > e9bfe0b38c1048ecc7fe634ed7b0d71fee6f2ac6 > > samza-operator/src/main/java/org/apache/samza/operators/api/internal/Trigger.java > 33a0134e88b966d8f08658f18ca73564702305fa > > samza-operator/src/main/java/org/apache/samza/operators/api/internal/WindowFn.java > 1fd88e76119960d1e6b83189bb571e64ac329489 > > samza-operator/src/main/java/org/apache/samza/operators/api/internal/WindowOutput.java > e202c20cb0af6e53268e0c80820bfb1d7fc80892 > > samza-operator/src/main/java/org/apache/samza/operators/impl/ChainedOperators.java > 59de16bd11fee34b23baac14d1d32cf9df555058 > > samza-operator/src/main/java/org/apache/samza/operators/impl/OperatorFactory.java > f16cbc6bf405851488c22b943a2256864b7a9f07 > > samza-operator/src/main/java/org/apache/samza/operators/impl/OperatorImpl.java > 3ca8bdeb7d73c72f469fa33a152ed7518f9e8ac4 > > samza-operator/src/main/java/org/apache/samza/operators/impl/ProcessorContext.java > 5a375bc7bb3b00fd252c6b1bbe211de8feddd942 > > samza-operator/src/main/java/org/apache/samza/operators/impl/SimpleOperatorImpl.java > b29d9c8c412c70820ac8355137df447d373af1f6 > > samza-operator/src/main/java/org/apache/samza/operators/impl/SinkOperatorImpl.java > 5d25cfa106424f45660a45434c4abffd242b8672 > > samza-operator/src/main/java/org/apache/samza/operators/impl/StateStoreImpl.java > f573fd04e1aaf827d2ca52a5edca8f7060723aa0 > > samza-operator/src/main/java/org/apache/samza/operators/impl/join/PartialJoinOpImpl.java > bbe08a404b306d07d93c75ce21d00aebc38b42c3 > > samza-operator/src/main/java/org/apache/samza/operators/impl/window/SessionWindowImpl.java > 59e2dec217bb7999ea3f42f106b55dd5563addcc > > samza-operator/src/main/java/org/apache/samza/task/StreamOperatorAdaptorTask.java > e340fe82109f8b59796fa2042dec2614671136b6 > samza-operator/src/main/java/org/apache/samza/task/StreamOperatorTask.java > cfdb694e337a663ce6fa179f0f3e91b05da51fa8 > > samza-operator/src/test/java/org/apache/samza/operators/api/TestMessage.java > 0f00fdbe7e2a2ddb4a4beb3cc77290221688cc97 > > samza-operator/src/test/java/org/apache/samza/operators/api/TestMessageStream.java > 9f9ad6bde2471f6c29e908cc8d3041e5e0deaf98 > > samza-operator/src/test/java/org/apache/samza/operators/api/TestMessageStreams.java > e6aa6923a9536651bc976f218bff94bc80e85e57 > > samza-operator/src/test/java/org/apache/samza/operators/api/TestOutputMessage.java > 225e77f04ede6803977559879ba30b976a6a962a > > samza-operator/src/test/java/org/apache/samza/operators/api/TestTriggerBuilder.java > 8faa92c08814cf19ef6e3e72dc21797db4ce11a1 > > samza-operator/src/test/java/org/apache/samza/operators/api/TestWindows.java > 47a37dca30a095b4dc74135d9bd76dc6bc8e91e2 > > samza-operator/src/test/java/org/apache/samza/operators/api/data/TestIncomingSystemMessage.java > e953078400340825be47450815b6fbbb1c19713d > > samza-operator/src/test/java/org/apache/samza/operators/api/data/TestLongOffset.java > 10775ec5c2cff70cd577e973e9fc11f21daa4592 > > samza-operator/src/test/java/org/apache/samza/operators/api/internal/TestOperators.java > 6dc77e5e448eb708b17fd8f79d02f91779b5690d > > samza-operator/src/test/java/org/apache/samza/operators/api/internal/TestTrigger.java > 727276a830d4427164de830866a4e8dfacde2abd > > samza-operator/src/test/java/org/apache/samza/operators/api/internal/TestWindowOutput.java > f3cf0e0de6091483b9fb72c9a0d137af2c89ccb4 > > samza-operator/src/test/java/org/apache/samza/operators/impl/TestChainedOperators.java > d4d23785709e6b5db08df0dc8513d3c956ab40db > > samza-operator/src/test/java/org/apache/samza/operators/impl/TestOperatorFactory.java > d228784df80a638a06f5e93388b9772066a67e6d > > samza-operator/src/test/java/org/apache/samza/operators/impl/TestOperatorImpl.java > d2961110735cd2e57ec1375586a3232675f63e93 > > samza-operator/src/test/java/org/apache/samza/operators/impl/TestProcessorContext.java > 14796fc365dd3819ef1c8b42be92174bce734ad0 > > samza-operator/src/test/java/org/apache/samza/operators/impl/TestSimpleOperatorImpl.java > c8c494418e17c640f07bbc5367d3d608cb909bb8 > > samza-operator/src/test/java/org/apache/samza/operators/impl/TestSinkOperatorImpl.java > e711bc564e931c50913cb7fcd6b8a36e5754c1ff > > samza-operator/src/test/java/org/apache/samza/operators/impl/TestStateStoreImpl.java > eb8937a0553305a0935c2f0d4bcaa646a22b6789 > > samza-operator/src/test/java/org/apache/samza/operators/impl/window/TestSessionWindowImpl.java > 75cb00c50bf52735ba0605f6a669e001e69d83a9 > > samza-operator/src/test/java/org/apache/samza/task/BroadcastOperatorTask.java > 724bbba15f7fe9b3eaf745cff9a037280688b892 > > samza-operator/src/test/java/org/apache/samza/task/InputJsonSystemMessage.java > 33ae9c963f30e5fe9ae19c24777d1a7d3d6ae862 > samza-operator/src/test/java/org/apache/samza/task/JoinOperatorTask.java > 825f4c471d9a0a8569c04ee9fb4bd45f35274d4d > > samza-operator/src/test/java/org/apache/samza/task/TestStreamOperatorAdaptorTask.java > 306425e26818fdb4968306f7d139fe6bffb046b6 > > samza-operator/src/test/java/org/apache/samza/task/TestStreamOperatorTasks.java > d6181eab1062f7776579322459b1a12ebde794a8 > samza-operator/src/test/java/org/apache/samza/task/WindowOperatorTask.java > 11186ea27895b82a8023df68323fe42518ad8a61 > > Diff: https://reviews.apache.org/r/53326/diff/ > > > Testing > ------- > > ./gradlew build passes > > > Thanks, > > Jagadish Venkatraman > >
