----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52436/#review151060 -----------------------------------------------------------
Ship it! Good catch! Thanks for fixing this! - Xinyu Liu On Sept. 30, 2016, 6:51 p.m., Jagadish Venkatraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52436/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2016, 6:51 p.m.) > > > Review request for samza, Navina Ramesh, Xinyu Liu, and Yi Pan (Data > Infrastructure). > > > Repository: samza > > > Description > ------- > > The Samza gradle settings are not setup correctly for joint compilation of > Java and Scala. When javac runs before scalac, the .java files that import > scala classes will fail compilation. This is because scalac has not run (and > hence, has not compiled the imported scala sources to class files). The > reverse problem occurs when scalac is run before javac - ie. the .scala files > that import java classes will fail compilation. > "Joint compilation" refers to compiling scala and java as a single > compilation unit. This will run the `scala` plugin to joint compile both java > and scala sources. > > > Diffs > ----- > > build.gradle 004c81e9173c22dee3e282aad2a58a34a3e46fe2 > > Diff: https://reviews.apache.org/r/52436/diff/ > > > Testing > ------- > > > Thanks, > > Jagadish Venkatraman > >
