----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52140/#review149931 -----------------------------------------------------------
Fix it, then Ship it! Some minor suggestions. docs/learn/documentation/versioned/operations/split-deployment.md (line 36) <https://reviews.apache.org/r/52140/#comment217708> is this <br> intended here? docs/learn/documentation/versioned/operations/split-deployment.md (line 48) <https://reviews.apache.org/r/52140/#comment217709> seems here are two "split deployment" bullets here. Do we want to distinguish the second and third type of deployments by naming? docs/learn/documentation/versioned/operations/split-deployment.md (line 65) <https://reviews.apache.org/r/52140/#comment217711> 1. => 2. docs/learn/documentation/versioned/operations/split-deployment.md (line 66) <https://reviews.apache.org/r/52140/#comment217712> 3. .. docs/learn/documentation/versioned/operations/split-deployment.md (line 90) <https://reviews.apache.org/r/52140/#comment217714> Since this is 0.11 release, can we use 0.11.0 acrose all examples here? docs/learn/documentation/versioned/operations/split-deployment.md (line 113) <https://reviews.apache.org/r/52140/#comment217715> I think we need to mention the framework libraries needed to be placed to each node in the cluster. - Xinyu Liu On Sept. 22, 2016, 12:48 a.m., Boris Shkolnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52140/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2016, 12:48 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > added docs for split deployment > > > Diffs > ----- > > docs/learn/documentation/versioned/operations/split-deployment.md > PRE-CREATION > > Diff: https://reviews.apache.org/r/52140/diff/ > > > Testing > ------- > > > Thanks, > > Boris Shkolnik > >
