----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/ -----------------------------------------------------------
(Updated Sept. 12, 2016, 9:25 p.m.) Review request for samza, Boris Shkolnik, Chris Pettitt, Yi Pan (Data Infrastructure), Navina Ramesh, and Xinyu Liu. Changes ------- In the process of addressing [~xiliu]'s feedback, I found two gaps: 1. Our checkstyle checks are not compatible with JDK 8. (SAMZA-1015) 2. Our gradle settings are not setup correctly for joint compilation.(SAMZA-1016) Repository: samza Description (updated) ------- Samza currently works with unbounded data sources (kafka streams). However, for bounded data sources like HDFS files, snapshot files which are not infinite, we need a notion of 'end-of-stream'. This is a step towards realizing a 'finite' Samza job that terminates once data processing is complete.(as opposed to an infinite stream job that keeps running) RB changes: - New interface for EndOfStreamListener - New 'end-of-stream' state in the state-machine of AsyncStreamTask (Invariant: When end-of-stream is reached there are no buffered messages, no-callbacks are in-flight and no-window or commit call shall be in progress) - Changes to allow clean shut-downs of the tasks/container/job for end-of-stream. Design Doc and Implementation Notes: https://issues.apache.org/jira/secure/attachment/12825119/ProposalforEndofStreaminSamza.pdf This RB depends on https://reviews.apache.org/r/51819/ and https://reviews.apache.org/r/51824/ (to be committed first) Diffs (updated) ----- build.gradle 004c81e9173c22dee3e282aad2a58a34a3e46fe2 checkstyle/checkstyle.xml 770b5e7f7a091198bbf53b3908600f9ac0caa4c7 checkstyle/import-control.xml 7e77702bcd5c32f7fdaf1558337505993c1abe06 gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java cc860cf7eb4d514736913c1dceaa80534b61d71a samza-api/src/main/java/org/apache/samza/system/SystemStreamPartitionIterator.java a8f858aa7e4f4ce436f450cf439fe1a102983c64 samza-api/src/main/java/org/apache/samza/task/EndOfStreamListenerTask.java PRE-CREATION samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java 1fed2fb52eaaa27aed2bb79db55172d6f799506d samza-core/src/main/java/org/apache/samza/clustermanager/ResourceRequestState.java 39897c76ba8bb123e2ce6a878a891c17d75b99d6 samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java a510bb0c5914c772438930d27f100b4d360c1296 samza-core/src/main/java/org/apache/samza/task/AsyncStreamTaskAdapter.java 1fc645673b7547b642830df5639c0b4fcd11c0d5 samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 89f6857014489aba2db4129bc2e26dfec5b10652 samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala a8355b944cad54faacf5eeb883d8f4b630440757 samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerProcessManager.java 57a5da6120d1fecc6b5f14db03123813a571f9b9 samza-core/src/test/java/org/apache/samza/container/TestLocalityManager.java 9661885c1278c0d1cf53aae61f502ae719adfd51 samza-core/src/test/java/org/apache/samza/container/grouper/task/TestTaskAssignmentManager.java d813fdcd17b963321df4a57708710c9e5a20aa92 samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java ca913dea79fecbcecdfd1010dc794318055c5764 samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala db2249ba73526ae1ca0a03eb5e497f2fe5cfed9c Diff: https://reviews.apache.org/r/51346/diff/ Testing ------- Unit tests to test scenarios for inorder processing, out-of-order processing and commit semantics. Thanks, Jagadish Venkatraman
