----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51613/#review148593 -----------------------------------------------------------
Ship it! lgtm! - Yi Pan (Data Infrastructure) On Sept. 2, 2016, 6:11 p.m., Tommy Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51613/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2016, 6:11 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-842 > https://issues.apache.org/jira/browse/SAMZA-842 > > > Repository: samza > > > Description > ------- > > Stop JmxServer properly when using ThreadJob. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala > 56881d4 > > Diff: https://reviews.apache.org/r/51613/diff/ > > > Testing > ------- > > Tested manually. > > > Thanks, > > Tommy Becker > >
