----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51252/#review147583 -----------------------------------------------------------
Ship it! While we're on the topic of logging: I found it useful to have a trace log for when the AsyncRunLoop gets unblocked in blockIfBusy. We already have one for when it blocks. - Prateek Maheshwari On Aug. 30, 2016, 3:01 p.m., Xinyu Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51252/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 3:01 p.m.) > > > Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure). > > > Repository: samza > > > Description > ------- > > SAMZA-1004: Fix some logging and javadoc issues for AsyncStreamTask > > > Diffs > ----- > > samza-api/src/main/java/org/apache/samza/task/AsyncStreamTask.java > 684ba0b77fca1c1c5fd8d740597d3b7fcdc0f5cb > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > f786fc08c8f7eced4f4084dc8326b288888b6422 > > Diff: https://reviews.apache.org/r/51252/diff/ > > > Testing > ------- > > gradlew clean build. > > > Thanks, > > Xinyu Liu > >
