----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51225/#review146145 -----------------------------------------------------------
Ship it! Ship It! - Yi Pan (Data Infrastructure) On Aug. 18, 2016, 10:12 p.m., Xinyu Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51225/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2016, 10:12 p.m.) > > > Review request for samza, Jake Maes and Yi Pan (Data Infrastructure). > > > Repository: samza > > > Description > ------- > > During the process of making kafka producer thread safe, I refactored the > code so the previous lazy init of producer in produce() is moved to start(), > resulting all the system registered will start the producer. This is causing > backward incompatibility issues since user might have multiple systems > defined but only a few of them getting used. Need to restore the lazy init. > > > Diffs > ----- > > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala > 5a165800c085f24ceeea8be36cbf8c032455cad1 > > Diff: https://reviews.apache.org/r/51225/diff/ > > > Testing > ------- > > Tested in local deployment and the system producer defined but not used was > not be inited. > > > Thanks, > > Xinyu Liu > >
