-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50670/
-----------------------------------------------------------

(Updated Aug. 1, 2016, 11:29 p.m.)


Review request for samza, Yi Pan (Data Infrastructure), Navina Ramesh, and 
Xinyu Liu.


Repository: samza


Description
-------

As a part of the AM-JC refactoring, we took out some metrics from 
SamzaAppMasterMetrics and moved them to samza-core. However, for existing jobs 
that rely on metrics for their monitoring/alerting, changing metric-names may 
break the jobs.

This change ensures that we still report basic metrics like failed containers, 
running containers, job health from Samza yarn for backwards-compat reasons.


Diffs
-----

  
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnClusterResourceManager.java
 1fac7f4e656be2d83f7448a1ae498ffe32f6f6db 
  
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala 
PRE-CREATION 

Diff: https://reviews.apache.org/r/50670/diff/


Testing (updated)
-------

1. Build succeeds and unit tests pass.
2. Verified with a sample test job that metrics were actually flowing using 
JvisualVM.


Thanks,

Jagadish Venkatraman

Reply via email to